Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addFlag function to add flag for pattern #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrjk990
Copy link

@mrjk990 mrjk990 commented Feb 28, 2023

for me arabic word did not match in route !
this method w'll fix it
$router = new \Bramus\Router\Router();
$router->addFlag('u');
$router->get('/search/movie/([\p{L}\d-]+)', 'search@movieByTitle');

for me arabic word didnot found and route !
this method w'll fix it
$router = new \Bramus\Router\Router();
$router->addFlag('u');
$router->get('/search/movie/([\p{L}\d\-]+)', 'search@movieByTitle');
@mrjk990 mrjk990 changed the title addFlag function to add flag for patter addFlag function to add flag for pattern Mar 1, 2023
@uvulpos
Copy link
Collaborator

uvulpos commented Jun 11, 2023

Hi @mrjk990,
what exactly does this cahnge do? I did not get the purpose of it yet. Would be also nice, if you would document it in the code as well, so that new maintainers do not revert you changes by accident 🙂

@uvulpos uvulpos added the require feedback use case of pr or issue is not fully clear yet label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
require feedback use case of pr or issue is not fully clear yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants