Skip to content

[t156029] account: fix memory issues in _post_load_data with many products #33004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BT-sschmid wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[t156029] account: fix memory issues in _post_load_data with many products #33004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions addons/account/models/chart_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from odoo.addons.base.models.ir_model import MODULE_UNINSTALL_FLAG
from odoo.exceptions import AccessError, UserError
from odoo.modules import get_resource_from_path
from odoo.tools import file_open, float_compare, get_lang, groupby, SQL
from odoo.tools import file_open, float_compare, get_lang, groupby, split_every, SQL
from odoo.tools.translate import code_translations, TranslationImporter

_logger = logging.getLogger(__name__)
Expand All @@ -32,7 +32,7 @@
)

TAX_TAG_DELIMITER = '||'

PRODUCTS_BATCH_SIZE = 2000

def preserve_existing_tags_on_taxes(env, module):
''' This is a utility function used to preserve existing previous tags during upgrade of the module.'''
Expand Down Expand Up @@ -665,14 +665,17 @@ def _post_load_data(self, template_code, company, template_data):
# that would, otherwise, just look empty all the time for the current user/company
sudoed_products = self.env['product.template'].sudo().search(self.env['product.template']._check_company_domain(company))

if company.account_sale_tax_id:
sudoed_products_sale = sudoed_products.filtered(
lambda p: p.taxes_id and not p.taxes_id.filtered_domain(p.taxes_id._check_company_domain(company)))
sudoed_products_sale._force_default_sale_tax(company)
if company.account_purchase_tax_id:
sudoed_products_purchase = sudoed_products.filtered(
lambda p: p.supplier_taxes_id and not p.supplier_taxes_id.filtered_domain(p.taxes_id._check_company_domain(company)))
sudoed_products_purchase._force_default_purchase_tax(company)
for batch in split_every(PRODUCTS_BATCH_SIZE, sudoed_products.with_context(prefetch_fields=False)):
if company.account_sale_tax_id:
sudoed_products_sale = batch.filtered(
lambda p: p.taxes_id and not p.taxes_id.filtered_domain(p.taxes_id._check_company_domain(company)))
sudoed_products_sale._force_default_sale_tax(company)
if company.account_purchase_tax_id:
sudoed_products_purchase = batch.filtered(
lambda p: p.supplier_taxes_id and not p.supplier_taxes_id.filtered_domain(p.taxes_id._check_company_domain(company)))
sudoed_products_purchase._force_default_purchase_tax(company)
# Reset all caches
self.env.invalidate_all()

# Display caba fields if there are caba taxes
if not company.parent_id and self.env['account.tax'].search([('tax_exigibility', '=', 'on_payment')]):
Expand Down