Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of BKE Taxonomy Model #142

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

puja-trivedi
Copy link
Collaborator

@puja-trivedi puja-trivedi commented Jan 24, 2025

GoogleSheet used to generate model

Modifications made to original googlesheet:
1)Removed 3 classes from 'Classes' tab because they are imported from other models (GeneAnnotation, ParcellationTerm, CellSpecimen).

…glesheet: 1)Removed 3 classes from 'Classes' tab because they are imported from other models (GeneAnnotation, ParcellationTerm, CellSpecimen).
@puja-trivedi
Copy link
Collaborator Author

puja-trivedi commented Jan 24, 2025

@lydiang -

  1. There is an unrecognized range (Observation) in the Slots tab row 19 (Cluster - contains_observation - Observation). Is this a typo; should it be ObservationMatrix or ObservationRow? Or do we need to define a class Observation

Change to ObservationRow

  1. I noticed that the Data Type column in the Slots tab is set to ignore so currently all the slots have a range:string, is this intentional?

not intentional. add columns as necessary

  1. Where is the BERS schema defined (such that we can correctly import the CellSpecimen class)? Should we move the BERS schema to this repo?

define locally in Taxonomy Model.

… Need to still add BERS and AnS schema. BERS is currently not in models repo and SchemaSheets has an error when AnS is added so need to debug issue.
@puja-trivedi puja-trivedi marked this pull request as draft January 24, 2025 21:22
…cluded range column in Slots tab and added a minimum_value column to replicated 'unsigned integer' type. Added CellSpecimen and ParcellationTerm back in Classes Tab (no longer importing from other schema) because BERS is internal to Allen and currently having error importing AnSRS(will debug that in the future).
@puja-trivedi puja-trivedi marked this pull request as ready for review February 14, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant