Skip to content

Use public directory for data and update code accordingly#25

Merged
tekrajchhetri merged 7 commits intomasterfrom
use-public-directory
Aug 27, 2025
Merged

Use public directory for data and update code accordingly#25
tekrajchhetri merged 7 commits intomasterfrom
use-public-directory

Conversation

@tekrajchhetri
Copy link
Collaborator

This pull requests makes the following update:

  1. Use the public directory to read the data.
  2. BBQS data are put into ui/public directory.
  3. Remove code that's used for local testing, e.g., not generating static build.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @tekrajchhetri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the application's data handling by transitioning from a server-side API route to directly serving data from the public directory. This change simplifies the data fetching mechanism, streamlines the build process by removing local testing configurations, and updates related UI components and filtering logic to reflect the new data source and simplified architecture.

Highlights

  • Data Relocation to Public Directory: The primary data file (output_kg.jsonl) is now located in ui/public, enabling static serving.
  • API Route Deprecation: The ui/app/api/data/route.ts file, which previously provided a server-side endpoint for data, has been removed.
  • Client-Side Data Processing: The data fetching and transformation logic, previously handled by the API route, has been integrated directly into ui/lib/data.ts for client-side processing of the statically served data.
  • Simplified Build and Development: Removal of the setup script and related local testing code in ui/package.json and ui/app/api/data/route.ts indicates a move towards a more straightforward static site generation approach.
  • UI and Filtering Streamlining: Unused UI elements and filtering options related to "quadrants" have been removed from ui/components/CommunityManager.tsx and ui/contexts/FilterContext.tsx, simplifying the user interface and data model.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tekrajchhetri tekrajchhetri merged commit 2c715e4 into master Aug 27, 2025
1 of 2 checks passed
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully refactors the data loading mechanism to use a static file from the public directory, removing the need for a separate API route. This simplifies the architecture and improves performance. The changes are well-aligned with the PR's objectives. I've identified a significant area of code duplication in ui/lib/data.ts where data transformation logic is repeated for development and production environments. I've provided a suggestion to refactor this into a single, maintainable function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant