-
Notifications
You must be signed in to change notification settings - Fork 1
Error fetching community members #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change attempts to fix a JSON parsing error by adding more detailed error logging. However, the root cause of the error is a misunderstanding of the API response format.
The API endpoint
/api/datareturns a single JSON object, not a JSONL stream. Therefore, trying to parse it line-by-line will fail, leading to theSyntaxError.Additionally, the API already performs the data transformation from raw knowledge graph entries to community members, including generating categories. The client-side transformation logic that follows this block is redundant and inefficient.
The correct approach is to parse the entire response as a single JSON object and use the data directly. This also has the benefit of removing the temporary
console.logstatements.I suggest replacing this block with code that parses the JSON and returns the data. This will make the subsequent transformation code in this function redundant, and it should be removed.