Skip to content

Changed consensus consts for finality certainty #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bahbah94 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Changed consensus consts for finality certainty #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55a963f
Changed consensus consts for finality certainty
bahbah94 Nov 18, 2024
c94f8ed
Fixed typo: Added comma in the parameters passed
aryanmishra29 Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions node/src/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ pub fn new_full_base(
force_authoring,
backoff_authoring_blocks,
babe_link,
block_proposal_slot_portion: SlotProportion::new(0.5),
block_proposal_slot_portion: SlotProportion::new(0.25) // changeed from 0.5, slower production rate,
Comment thread
aryanmishra29 marked this conversation as resolved.
Outdated
max_block_proposal_slot_portion: None,
telemetry: telemetry.as_ref().map(|x| x.handle()),
};
Expand Down Expand Up @@ -681,8 +681,8 @@ pub fn new_full_base(

let grandpa_config = grandpa::Config {
// FIXME #1578 make this available through chainspec
gossip_duration: std::time::Duration::from_millis(333),
justification_period: 512,
gossip_duration: Duration::from_millis(1000), // Changed from 333
justification_period: 256,
name: Some(name),
observer_enabled: false,
keystore,
Expand Down
4 changes: 2 additions & 2 deletions runtime/gpu/constants/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ pub mod currency {
pub mod time {
use primitives::{BlockNumber, Moment};
use runtime_common::prod_or_fast;
pub const MILLISECS_PER_BLOCK: Moment = 6000;
pub const MILLISECS_PER_BLOCK: Moment = 12000;// Increase to 12 seconds;
pub const SLOT_DURATION: Moment = MILLISECS_PER_BLOCK;
pub const EPOCH_DURATION_IN_SLOTS: BlockNumber = prod_or_fast!(4 * HOURS, 1 * MINUTES); //shubhchange
pub const EPOCH_DURATION_IN_SLOTS: BlockNumber = prod_or_fast!(2 * HOURS, 1 * MINUTES); //shubhchange

// These time units are defined in number of blocks.
pub const MINUTES: BlockNumber = 60_000 / (MILLISECS_PER_BLOCK as BlockNumber);
Expand Down
6 changes: 4 additions & 2 deletions runtime/gpu/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,8 +553,8 @@ impl OnUnbalanced<NegativeImbalance<Runtime>> for SudoAccount {
}

parameter_types! {
// Six sessions in an era (24 hours).
pub const SessionsPerEra: SessionIndex = prod_or_fast!(6, 1);//shubhchange
// Six sessions in an era (24 hours). Changed to 4
pub const SessionsPerEra: SessionIndex = prod_or_fast!(4, 1);//shubhchange

// 28 eras for unbonding (28 days).
pub const BondingDuration: sp_staking::EraIndex = 28;
Expand Down Expand Up @@ -748,6 +748,8 @@ impl pallet_grandpa::Config for Runtime {
type MaxAuthorities = MaxAuthorities;
type MaxSetIdSessionEntries = MaxSetIdSessionEntries;



type KeyOwnerProof = <Historical as KeyOwnerProofSystem<(KeyTypeId, GrandpaId)>>::Proof;

type EquivocationReportSystem =
Expand Down