fix: reduce combat separation to SC2-level tightness#1382
Merged
Conversation
In-range attacking units were still spreading because processAttackingUnit applies separation at combatSpreadSpeedMultiplier * maxSpeed when force exceeds combatSeparationThreshold. With strength 0.3 and 8+ tightly-packed allies, force easily exceeded the 0.3 threshold, moving units at 0.75 units/sec - accumulating to 3.75 units of drift over 5 seconds of fighting. Changes: - strengthCombat: 0.3 → 0.1 (near-zero per-neighbor separation force) - spreadSpeedMultiplier: 0.25 → 0.1 (much slower combat spreading) - separationThreshold: 0.3 → 0.8 (only move when severely overlapping) With these values, 8 neighbors at typical combat distance generate ~0.39 force - well below the 0.8 threshold. Units effectively stay put while fighting, matching SC2 behavior where attacking units stack tightly. https://claude.ai/code/session_012Sc49F3UHGXxttLJpBPggB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-range attacking units were still spreading because processAttackingUnit applies separation at combatSpreadSpeedMultiplier * maxSpeed when force exceeds combatSeparationThreshold. With strength 0.3 and 8+ tightly-packed allies, force easily exceeded the 0.3 threshold, moving units at 0.75 units/sec - accumulating to 3.75 units of drift over 5 seconds of fighting.
Changes:
With these values, 8 neighbors at typical combat distance generate ~0.39 force - well below the 0.8 threshold. Units effectively stay put while fighting, matching SC2 behavior where attacking units stack tightly.
https://claude.ai/code/session_012Sc49F3UHGXxttLJpBPggB