fix: ensure all units in attack groups engage enemies#1374
Merged
Conversation
Previously, when AI issued attack commands to groups of units: 1. Only front-line units would engage - back units stayed idle 2. Back units drifted backwards away from combat Root causes: - CombatSystem skipped target acquisition for units not in "hot cells" - FlockingBehavior caused idle units to yield to moving units - Back units had no cohesion pulling them toward the fight This fix adds a hasActiveAttackCommand flag to track units that are advancing toward combat. These units now: - Always search for targets at sight range (not throttled) - Don't yield to physics push from other moving units - Have cohesion toward engaging allies - Use combat-level separation to stay grouped Changes: - SpatialGrid: Add hasActiveAttackCommand to inline entity data - MovementOrchestrator: Pass hasActiveAttackCommand to spatial grid - CombatSystem: Attack-moving units use aggressive target acquisition - FlockingBehavior: Units with attack commands don't yield, cohere toward allies, and use tight separation https://claude.ai/code/session_01MAHtq37jrekhgXFQT7H1Vh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when AI issued attack commands to groups of units:
Root causes:
This fix adds a hasActiveAttackCommand flag to track units that are advancing toward combat. These units now:
Changes:
https://claude.ai/code/session_01MAHtq37jrekhgXFQT7H1Vh