Claude/fix border decoration sidebar p phks#1368
Conversation
- Fix border decoration style buttons not showing selection state by using inline border instead of Tailwind ring-1 class - Change Edit, Set, and Val panel tab icons from text characters to proper emoji (✏️, ⚙️, ✅) so they render in full color like others - Add warning in validation panel that decoration objects (rocks, crystals, trees) are not checked and may block paths in-game https://claude.ai/code/session_01UnWTjozj4zuimX5Hy6TC1S
- Create EditorNavigation service that builds navmesh exactly like game - Uses same NAVMESH_CONFIG from pathfinding.config.ts - Generates walkable geometry same as Terrain.generateWalkableGeometry() - Adds decoration obstacles (rocks, crystals, trees) to navmesh - Runs actual pathfinding queries between bases - Update validation provider to use real navmesh pathfinding - Replaces 2D grid flood-fill with Recast Navigation - Tests paths between all main bases and naturals - Reports blocked paths as errors (main bases) or warnings (naturals) - Add auto-regenerate for border decorations in sidebar - Changing style or density now automatically updates decorations - Only triggers if decorations already exist on map - Update ValidatePanel UI for navmesh results - Shows navmesh generation status - Displays paths checked/found/blocked stats - Updated help text to explain new validation system If editor validation passes, game pathfinding is guaranteed to work. https://claude.ai/code/session_01UnWTjozj4zuimX5Hy6TC1S
- Add borderScale state (default 2.0x) for controlling decoration size - Scale range from 0.5x to 4.0x with 0.5 step increments - scaleMin/scaleMax are derived from borderScale (0.6x and 1.4x multipliers) - Scale changes auto-regenerate decorations like style and density do https://claude.ai/code/session_01UnWTjozj4zuimX5Hy6TC1S
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff76e28614
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const startQuery = { x: startX, y: 0, z: startY }; | ||
| const endQuery = { x: endX, y: 0, z: endY }; |
There was a problem hiding this comment.
Here findPath always queries the navmesh at y: 0, but the in‑game implementation uses the terrain height for better accuracy (RecastNavigation.findPath calls getTerrainHeight before findClosestPoint). On maps with elevated terrain (height > ~3, given your half‑extents), findClosestPoint can miss the correct polygon and falsely report blocked paths even when the navmesh is connected. This can surface as spurious validation errors for high‑elevation bases or ramps.
Useful? React with 👍 / 👎.
braedonsaunders
deleted the
claude/fix-border-decoration-sidebar-pPHKS
branch
2 participants
No description provided.