fix: add targeting capability fields to UnitRenderState for battle si…#1367
Merged
Conversation
…mulator The battle simulator's Fight button wasn't working because the findValidTarget() function needed isNaval, canAttackGround, and canAttackAir fields which weren't being sent in the render state. - Add isNaval, canAttackGround, canAttackAir to UnitRenderState interface - Update GameWorker to send these fields in the render state - Update UnitAdapter to expose these fields to the main thread - Remove debug logging from BattleSimulatorPanel https://claude.ai/code/session_01RByrKsfTJ9jf3kCjztLrY5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mulator
The battle simulator's Fight button wasn't working because the findValidTarget() function needed isNaval, canAttackGround, and canAttackAir fields which weren't being sent in the render state.
https://claude.ai/code/session_01RByrKsfTJ9jf3kCjztLrY5