fix: restore transparent rendering and opacity for water visibility#1337
Merged
Merged
Conversation
The water was not rendering because the material was set to opaque mode with depthWrite=true but returning just a vec3 from colorNode. The original working version used transparent rendering. Changes: - Add opacity field to QualitySettings (0.85-0.92 based on quality) - Add uOpacity uniform for dynamic opacity control - Update colorNode to return vec4(color, opacity) instead of vec3 - Restore transparent rendering settings: - material.transparent = true - material.side = THREE.DoubleSide - material.depthWrite = false - Fix stale comment in normalNode section (confirms [0,1] encoding is correct) The white-out fix (removing manual fresnel/specular) is preserved. The depth sorting fix (consistent water level per region) is preserved. https://claude.ai/code/session_01ChDF73v8WwcjKe7cWV82iB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The water was not rendering because the material was set to opaque mode with depthWrite=true but returning just a vec3 from colorNode. The original working version used transparent rendering.
Changes:
The white-out fix (removing manual fresnel/specular) is preserved. The depth sorting fix (consistent water level per region) is preserved.
https://claude.ai/code/session_01ChDF73v8WwcjKe7cWV82iB