fix: restore MeshStandardNodeMaterial and normal encoding for water r…#1335
Merged
Merged
Conversation
…endering The water was not rendering because: 1. MeshPhysicalNodeMaterial was incorrectly used (IOR-based approach) 2. normalNode was returning [-1,1] range when TSL expects [0,1] encoded Changes: - Switch back to MeshStandardNodeMaterial for consistent PBR - Add .mul(0.5).add(0.5) encoding to normalNode (matches TerrainMaterial) - Remove WATER_IOR constant (not needed with MeshStandardNodeMaterial) - Update documentation to clarify TSL normalNode convention The white-out issue was caused by double-lighting (manual fresnel/specular in colorNode combined with PBR pipeline), not normal encoding. The previous fixes correctly removed manual lighting; this commit restores the normal encoding that TSL requires. https://claude.ai/code/session_01ChDF73v8WwcjKe7cWV82iB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…endering
The water was not rendering because:
Changes:
The white-out issue was caused by double-lighting (manual fresnel/specular in colorNode combined with PBR pipeline), not normal encoding. The previous fixes correctly removed manual lighting; this commit restores the normal encoding that TSL requires.
https://claude.ai/code/session_01ChDF73v8WwcjKe7cWV82iB