Skip to content

fix: address code quality issues across networking and workers #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braedonsaunders merged 3 commits into from
Feb 3, 2026
Merged

fix: address code quality issues across networking and workers #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1980855
fix: address code quality issues across networking and workers
claude Feb 3, 2026
e541e26
fix: move STUN config to JSON, remove duplicate TS ability definitions
claude Feb 3, 2026
7b5a47c
fix: remove all SC2 race references, use 'dominion' as default faction
claude Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions public/data/networking.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"iceServers": [
{ "urls": "stun:stun.l.google.com:19302" },
{ "urls": "stun:stun1.l.google.com:19302" },
{ "urls": "stun:stun2.l.google.com:19302" },
{ "urls": "stun:stun3.l.google.com:19302" }
]
}
6 changes: 3 additions & 3 deletions src/assets/AssetManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,7 @@ function cloneModel(original: THREE.Object3D, assetId: string): THREE.Object3D {

// Standard materials library
export const Materials = {
// Dominion (Terran-like) faction
// Dominion faction
dominion: {
metal: new THREE.MeshStandardMaterial({
color: 0x6080a0,
Expand Down Expand Up @@ -735,7 +735,7 @@ export const Materials = {
}),
},

// Synthesis (Protoss-like) faction
// Synthesis faction (placeholder)
synthesis: {
crystal: new THREE.MeshStandardMaterial({
color: 0x4080ff,
Expand All @@ -758,7 +758,7 @@ export const Materials = {
}),
},

// Swarm (Zerg-like) faction
// Swarm faction (placeholder)
swarm: {
chitin: new THREE.MeshStandardMaterial({
color: 0x4a3040,
Expand Down
Loading
Loading