fix: preserve spectator audio behavior in MainThreadEventHandler#1304
Merged
Conversation
Previously, MainThreadEventHandler was updated to take localPlayerId as a constructor parameter with a fallback to 'player1'. This broke spectator mode because spectators (localPlayerId=null) were incorrectly treated as player1, causing them to hear local-only audio/alerts. Changes: - Accept null localPlayerId (spectator mode) instead of defaulting to 'player1' - Add setLocalPlayerId() method to update player ID when it changes mid-session - Subscribe to store changes to handle spectator mode transitions (e.g., after player defeat via enableSpectatorMode()) This restores the original behavior where spectators stay silent for local-only audio events. https://claude.ai/code/session_01Uc8iUFPTi7sjC8S94BxAbY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, MainThreadEventHandler was updated to take localPlayerId as a constructor parameter with a fallback to 'player1'. This broke spectator mode because spectators (localPlayerId=null) were incorrectly treated as player1, causing them to hear local-only audio/alerts.
Changes:
This restores the original behavior where spectators stay silent for local-only audio events.
https://claude.ai/code/session_01Uc8iUFPTi7sjC8S94BxAbY