Skip to content

fix: remove useTemporalFiltering (not available in GTAONode) #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braedonsaunders merged 1 commit into from
Feb 3, 2026
Merged

fix: remove useTemporalFiltering (not available in GTAONode) #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/rendering/tsl/PostProcessing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,6 @@ export class RenderPipeline {
radius: this.config.aoRadius,
intensity: this.config.aoIntensity,
samples: 32, // Higher samples = less visible dithering pattern
useTemporalFiltering: this.config.taaEnabled, // Smooth AO over frames when TAA is on
},
scenePassNormal
);
Expand Down
6 changes: 0 additions & 6 deletions src/rendering/tsl/effects/EffectPasses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ export interface GTAOConfig {
radius: number;
intensity: number;
samples?: number; // Number of AO samples (higher = better quality, more expensive)
useTemporalFiltering?: boolean; // Enable temporal filtering to reduce noise (requires TAA)
}

export interface SSRConfig {
Expand Down Expand Up @@ -214,11 +213,6 @@ export function createGTAOPass(
if (aoPass.samples) {
aoPass.samples.value = config.samples ?? 32;
}
// Enable temporal filtering to reduce noise when TAA is available
// This smooths the AO over multiple frames, eliminating the stipple pattern
if (config.useTemporalFiltering !== undefined) {
aoPass.useTemporalFiltering = config.useTemporalFiltering;
}
const aoValueNode = aoPass.getTextureNode().r;

return { pass: aoPass, aoValueNode };
Expand Down
Loading