fix: add destroyed entity validation across game systems#1290
Merged
Conversation
- Add validateEntityAlive() helper to EntityValidator that checks both null and isDestroyed() state for stored entity ID references - Apply systematic isDestroyed() checks to 30+ locations across: - CombatSystem: attack queue, target acquisition, splash damage - ResourceSystem: gather commands, worker update, resource return - ProjectileSystem: homing targets, impact damage, splash damage - AbilitySystem: all ability executions and delayed effects - MovementOrchestrator: attack-move, patrol, attacking units - ProductionSystem: production/cancel/reorder commands, upgrades - Remove unused dead code from graphics settings: - taaHistoryBlendRate from uiStore and PostProcessing - outlineEnabled/outlineStrength from uiStore (never wired up) This prevents potential bugs from operating on destroyed entities during the same tick they're marked for destruction. https://claude.ai/code/session_01UmxaG5s7rB9Y6hcEBxw7Mf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents potential bugs from operating on destroyed entities during the same tick they're marked for destruction.
https://claude.ai/code/session_01UmxaG5s7rB9Y6hcEBxw7Mf