Skip to content

fix: show enemy units and buildings when fog of war is disabled #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braedonsaunders merged 1 commit into from
Feb 3, 2026
Merged

fix: show enemy units and buildings when fog of war is disabled #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/rendering/BuildingRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { getPlayerColor, isSpectatorMode } from '@/store/gameSetupStore';
import { useUIStore } from '@/store/uiStore';
import { debugMesh } from '@/utils/debugLogger';
import { CullingService, EntityCategory } from './services/CullingService';
import { getConsoleEngineSync } from '@/engine/debug/ConsoleEngine';
import { BUILDING_RENDERER, BUILDING_SELECTION_RING, RENDER_ORDER } from '@/data/rendering.config';
import {
createConstructingMaterial,
Expand Down Expand Up @@ -648,10 +649,13 @@ export class BuildingRenderer {
const isOwned = !isSpectating && ownerId === this.playerId;
const isEnemy = !isSpectating && selectable && ownerId !== this.playerId;

// Check visibility for enemy buildings (skip in spectator mode - show all)
// Check visibility for enemy buildings (skip in spectator mode or if fog disabled - show all)
let shouldShow = true;
if (isEnemy && this.visionSystem && this.playerId) {
shouldShow = this.visionSystem.isExplored(this.playerId, transform.x, transform.y);
const fogDisabled = getConsoleEngineSync()?.getFlag('fogDisabled');
if (!fogDisabled) {
shouldShow = this.visionSystem.isExplored(this.playerId, transform.x, transform.y);
}
}

// PERF: Get cached terrain height (buildings rarely move)
Expand Down
8 changes: 6 additions & 2 deletions src/rendering/UnitRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {

// GPU-driven rendering infrastructure
import { CullingService, EntityCategory } from './services/CullingService';
import { getConsoleEngineSync } from '@/engine/debug/ConsoleEngine';
import { LODConfig } from './compute/UnifiedCullingCompute';
import { GPUIndirectRenderer } from './compute/GPUIndirectRenderer';

Expand Down Expand Up @@ -1013,10 +1014,13 @@ export class UnitRenderer {
const isOwned = !isSpectating && ownerId === this.playerId;
const isEnemy = !isSpectating && selectable && ownerId !== this.playerId;

// Check visibility for enemy units (skip in spectator mode - show all)
// Check visibility for enemy units (skip in spectator mode or if fog disabled - show all)
let shouldShow = true;
if (isEnemy && this.visionSystem && this.playerId) {
shouldShow = this.visionSystem.isVisible(this.playerId, transform.x, transform.y);
const fogDisabled = getConsoleEngineSync()?.getFlag('fogDisabled');
if (!fogDisabled) {
shouldShow = this.visionSystem.isVisible(this.playerId, transform.x, transform.y);
}
}

// Skip dead units
Expand Down
Loading