Skip to content

fix: clear ALL texture maps on all models in AssetManager #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braedonsaunders merged 1 commit into from
Feb 3, 2026
Merged

fix: clear ALL texture maps on all models in AssetManager #1287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 33 additions & 29 deletions src/assets/AssetManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,22 +1086,24 @@ export class AssetManager {
// Fix materials - AI-generated models often have issues
const materials = Array.isArray(child.material) ? child.material : [child.material];
for (const mat of materials) {
if (mat) {
if (mat && (mat as THREE.MeshStandardMaterial).isMeshStandardMaterial) {
const stdMat = mat as THREE.MeshStandardMaterial;
// Disable vertex colors - AI models bake AO into vertex colors
if ('vertexColors' in mat) {
mat.vertexColors = false;
}
// Clear any aoMap/lightMap that might be causing artifacts
// These maps often use UV2 which gets stripped, causing visual issues
if ('aoMap' in mat) {
(mat as THREE.MeshStandardMaterial).aoMap = null;
(mat as THREE.MeshStandardMaterial).aoMapIntensity = 0;
}
if ('lightMap' in mat) {
(mat as THREE.MeshStandardMaterial).lightMap = null;
(mat as THREE.MeshStandardMaterial).lightMapIntensity = 0;
}
mat.needsUpdate = true;
stdMat.vertexColors = false;
// Clear ALL texture maps that could cause triangular artifacts
// AI-generated models often have corrupted or low-quality maps
stdMat.aoMap = null;
stdMat.aoMapIntensity = 0;
stdMat.lightMap = null;
stdMat.lightMapIntensity = 0;
stdMat.normalMap = null;
stdMat.normalScale.set(1, 1);
stdMat.bumpMap = null;
stdMat.displacementMap = null;
stdMat.metalnessMap = null;
stdMat.roughnessMap = null;
stdMat.alphaMap = null;
stdMat.needsUpdate = true;
}
}

Expand Down Expand Up @@ -1199,21 +1201,23 @@ export class AssetManager {
// Fix materials - AI-generated models often have issues
const materials = Array.isArray(child.material) ? child.material : [child.material];
for (const mat of materials) {
if (mat) {
if (mat && (mat as THREE.MeshStandardMaterial).isMeshStandardMaterial) {
const stdMat = mat as THREE.MeshStandardMaterial;
// Disable vertex colors - AI models bake AO into vertex colors
if ('vertexColors' in mat) {
mat.vertexColors = false;
}
// Clear any aoMap/lightMap that might be causing artifacts
if ('aoMap' in mat) {
(mat as THREE.MeshStandardMaterial).aoMap = null;
(mat as THREE.MeshStandardMaterial).aoMapIntensity = 0;
}
if ('lightMap' in mat) {
(mat as THREE.MeshStandardMaterial).lightMap = null;
(mat as THREE.MeshStandardMaterial).lightMapIntensity = 0;
}
mat.needsUpdate = true;
stdMat.vertexColors = false;
// Clear ALL texture maps that could cause triangular artifacts
stdMat.aoMap = null;
stdMat.aoMapIntensity = 0;
stdMat.lightMap = null;
stdMat.lightMapIntensity = 0;
stdMat.normalMap = null;
stdMat.normalScale.set(1, 1);
stdMat.bumpMap = null;
stdMat.displacementMap = null;
stdMat.metalnessMap = null;
stdMat.roughnessMap = null;
stdMat.alphaMap = null;
stdMat.needsUpdate = true;
}
}

Expand Down
Loading