fix: resolve triangle artifacts by fixing normalView TSL variable ini…#1276
Merged
Conversation
…tialization The root cause was Three.js GitHub issue #32009 - TSL's normalView variable may not be properly initialized in MRT shader contexts, causing black/undefined normals for some pixels. When GTAO receives zero normals, it falls back to depth-based normal reconstruction which creates visible triangular artifacts. Using .toVar() forces proper variable initialization in the shader, ensuring all pixels have valid normals in the MRT output. https://claude.ai/code/session_012kqvccEiiHNQHAjUEoposi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tialization
The root cause was Three.js GitHub issue #32009 - TSL's normalView variable may not be properly initialized in MRT shader contexts, causing black/undefined normals for some pixels. When GTAO receives zero normals, it falls back to depth-based normal reconstruction which creates visible triangular artifacts.
Using .toVar() forces proper variable initialization in the shader, ensuring all pixels have valid normals in the MRT output.
https://claude.ai/code/session_012kqvccEiiHNQHAjUEoposi