fix: remove incorrect V-flip from fog shader - use direct worldZ/mapH…#1248
Merged
Conversation
…eight The shader UV calculation had an incorrect Y-flip that inverted vision: - OLD: visionV = 1.0 - worldZ/mapHeight (WRONG) - NEW: visionV = worldZ/mapHeight (CORRECT) Root cause analysis: - Game transform.y (depth) → Three.js position.z → shader worldZ - Vision grid stores visionGrid[cellY] where cellY = floor(worldZ/cellSize) - Texture row cellY maps to UV v = cellY/gridHeight - Therefore visionV should equal worldZ/mapHeight with NO flip This was causing: - 6p test map: wrong starting base revealed (y=60/320 → v=0.81 → sampled north) - Both maps: moving south revealed north (inverted direction) Also updated VisionCompute.ts comment to clarify coordinate transformation. https://claude.ai/code/session_013Hqn3PxBW8h7hpMNMKKv1e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eight
The shader UV calculation had an incorrect Y-flip that inverted vision:
Root cause analysis:
This was causing:
Also updated VisionCompute.ts comment to clarify coordinate transformation.
https://claude.ai/code/session_013Hqn3PxBW8h7hpMNMKKv1e