fix: use worldZ (depth) with V-flip in fog shader for correct vision …#1246
Merged
Conversation
…mapping In Three.js reconstructed world space, worldY is altitude and worldZ is depth (north-south). The previous fix incorrectly used worldY which was nearly 0 for ground units, resulting in no fog being lifted. This fix uses worldZ (the actual depth coordinate) with a V-flip to ensure that moving south reveals the south part of the map, not the north. https://claude.ai/code/session_013Hqn3PxBW8h7hpMNMKKv1e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mapping
In Three.js reconstructed world space, worldY is altitude and worldZ is depth (north-south). The previous fix incorrectly used worldY which was nearly 0 for ground units, resulting in no fog being lifted.
This fix uses worldZ (the actual depth coordinate) with a V-flip to ensure that moving south reveals the south part of the map, not the north.
https://claude.ai/code/session_013Hqn3PxBW8h7hpMNMKKv1e