Skip to content

fix: use worldY (depth) in fog shader, remove CPU Y-flip #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braedonsaunders merged 1 commit into from
Feb 2, 2026
Merged

fix: use worldY (depth) in fog shader, remove CPU Y-flip #1244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/rendering/tsl/FogOfWar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,8 @@ export class TSLFogOfWar {
// Update CPU texture from vision grid with temporal smoothing
for (let y = 0; y < this.gridHeight; y++) {
for (let x = 0; x < this.gridWidth; x++) {
// Flip Y for texture coordinates
const textureY = this.gridHeight - 1 - y;
const i = textureY * this.gridWidth + x;
// No Y-flip - matches GPU path (VisionCompute) which writes directly to (cellX, cellY)
const i = y * this.gridWidth + x;
const state = visionGrid[y]?.[x] ?? 'unexplored';

// Current visibility (target)
Expand Down Expand Up @@ -281,9 +280,8 @@ export class TSLFogOfWar {
// Update CPU texture from serialized data with temporal smoothing
for (let y = 0; y < this.gridHeight; y++) {
for (let x = 0; x < this.gridWidth; x++) {
// Flip Y for texture coordinates
const textureY = this.gridHeight - 1 - y;
const textureIndex = textureY * this.gridWidth + x;
// No Y-flip - matches GPU path (VisionCompute)
const textureIndex = y * this.gridWidth + x;
const dataIndex = y * this.gridWidth + x;
const state = serializedData[dataIndex];

Expand Down
3 changes: 2 additions & 1 deletion src/rendering/tsl/effects/EffectPasses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,8 +770,9 @@ export function createFogOfWarPass(
const worldZ = worldPos4.z;

// Convert world position to vision grid UV
// Note: This codebase uses Y as depth (north-south), not Z
const visionU = worldX.div(uMapDimensions.x);
const visionV = worldZ.div(uMapDimensions.y);
const visionV = worldY.div(uMapDimensions.y);
const visionUV = vec2(visionU, visionV).toVar();

// Clamp to valid range
Expand Down
Loading