fix: update getEntitiesWith to handle Selectable component queries#1230
Merged
Conversation
SelectionSystem queries for entities using getEntitiesWith('Transform', 'Selectable'),
but RenderStateWorldAdapter was only returning entities for 'Unit' or 'Transform' alone
queries. This caused the selection system to receive no entities when trying to select.
Updated getEntitiesWith to properly handle Selectable queries:
- ('Transform', 'Selectable') now returns both units and buildings
- Explicit conditions for when to include units, buildings, and resources
- Added documentation for supported query patterns
https://claude.ai/code/session_01VWGwpnz8yMDkYjicbv2dZ7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelectionSystem queries for entities using getEntitiesWith('Transform', 'Selectable'), but RenderStateWorldAdapter was only returning entities for 'Unit' or 'Transform' alone queries. This caused the selection system to receive no entities when trying to select.
Updated getEntitiesWith to properly handle Selectable queries:
https://claude.ai/code/session_01VWGwpnz8yMDkYjicbv2dZ7