refactor: Remove deprecated exports and migrate to DefinitionRegistry#1202
Merged
Conversation
- Remove deprecated shiftHeld property from GameCommand (use queue instead) - Remove deprecated DOMINION_UNITS, DOMINION_BUILDINGS, DOMINION_RESEARCH, and WALL_BUILDINGS proxy array exports - Remove deprecated generateCommandId/resetCommandIdCounter wrapper functions - Migrate BattleSimulatorPanel to use DefinitionRegistry.getAllUnits() - Update tests to use commandIdGenerator directly and WALL_DEFINITIONS - Keep legacy remotePeerId as fallback for single-peer multiplayer mode The deprecated proxy arrays were unused backwards-compatibility shims. All code now uses DefinitionRegistry directly for definition access. https://claude.ai/code/session_013kqzknKuFTPmimEQVm47Ch
braedonsaunders
force-pushed
the
claude/remove-deprecated-exports-43vcs
branch
from
93427ff to
5f83a73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecated proxy arrays were unused backwards-compatibility shims. All code now uses DefinitionRegistry directly for definition access.
https://claude.ai/code/session_013kqzknKuFTPmimEQVm47Ch