Skip to content

refactor: Remove unused lastEnemyCheckResult from CombatSystem #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braedonsaunders merged 1 commit into from
Jan 31, 2026
Merged

refactor: Remove unused lastEnemyCheckResult from CombatSystem #1197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/engine/systems/CombatSystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,6 @@ export class CombatSystem extends System {
// RTS-STYLE: Reduced from 15 to 5 ticks for more responsive combat detection
private readonly COMBAT_ZONE_CHECK_INTERVAL = 5; // Re-check zone every 5 ticks (~250ms)

// PERF: Track player unit counts per grid cell for fast enemy detection
private lastEnemyCheckResult: Map<number, boolean> = new Map();

// PERF OPTIMIZATION: Combat-active entity list
// Only units in this set are processed for target acquisition
private combatActiveUnits: Set<number> = new Set();
Expand Down Expand Up @@ -364,7 +361,6 @@ export class CombatSystem extends System {
// PERF: Clean up combat zone tracking
this.combatAwareUnits.delete(data.entityId);
this.combatZoneCheckTick.delete(data.entityId);
this.lastEnemyCheckResult.delete(data.entityId);
}

private handleAttackCommand(command: {
Expand Down