fix: Address console errors - spawn warning, TSL texture, missing audio#1192
Merged
Merged
Conversation
1. GameWorker.ts: Change duplicate spawn warning from console.warn to
debugInitialization.log since the guard is working correctly
2. VolumetricFog.ts: Fix THREE.TSL texture error by using .sample() on the
depth texture node instead of texture() - the depthTexture parameter is
already a texture node from scenePass.getTextureNode('depth')
3. sounds.config.json: Use yamato.mp3 for power_cannon sound effect since
power_cannon.mp3 doesn't exist in the audio assets
https://claude.ai/code/session_0123HA6ovqXT4Gk6EyLXoc3h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GameWorker.ts: Change duplicate spawn warning from console.warn to debugInitialization.log since the guard is working correctly
VolumetricFog.ts: Fix THREE.TSL texture error by using .sample() on the depth texture node instead of texture() - the depthTexture parameter is already a texture node from scenePass.getTextureNode('depth')
sounds.config.json: Use yamato.mp3 for power_cannon sound effect since power_cannon.mp3 doesn't exist in the audio assets
https://claude.ai/code/session_0123HA6ovqXT4Gk6EyLXoc3h