fix: Await definition loading in worker context before creating game#1177
Merged
Merged
Conversation
The worker runs in a separate JavaScript context from the main thread, so it has its own DefinitionRegistry singleton that needs to be initialized independently. Previously, initializeDefinitions() was only called on the main thread, causing the worker's GameCore constructor to fire off an async bootstrapDefinitions() call that didn't complete before systems tried to access definitions. This fix awaits initializeDefinitions() in the worker's 'init' message handler before creating WorkerGame, ensuring definitions are fully loaded in the worker context. https://claude.ai/code/session_0123HA6ovqXT4Gk6EyLXoc3h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The worker runs in a separate JavaScript context from the main thread, so it has its own DefinitionRegistry singleton that needs to be initialized independently.
Previously, initializeDefinitions() was only called on the main thread, causing the worker's GameCore constructor to fire off an async bootstrapDefinitions() call that didn't complete before systems tried to access definitions.
This fix awaits initializeDefinitions() in the worker's 'init' message handler before creating WorkerGame, ensuring definitions are fully loaded in the worker context.
https://claude.ai/code/session_0123HA6ovqXT4Gk6EyLXoc3h