Claude/fix unit animations f9 vu p#1156
Merged
Merged
Conversation
The UnitRenderer uses Velocity component data to determine if a unit is
moving (for walk/idle animation transitions). In worker mode, entities
come from RenderStateWorldAdapter which was missing a VelocityAdapter,
causing entity.get('Velocity') to always return undefined.
This resulted in isMoving always being false, so units would only play
idle animations even while moving.
The fix adds a VelocityAdapter that derives velocity from position delta
(current - previous) using the prevX/prevY data already in UnitRenderState.
https://claude.ai/code/session_01NUQdm7SkEPq2rQZcSFmRQf
The RenderStateWorldAdapter was missing several properties that renderers need for proper functionality in worker mode: Units: - targetX, targetY: needed for CommandQueueRenderer waypoint visualization - commandQueue: needed for shift-click command queue visualization - attackRange, sightRange: needed for GameOverlay range ring rendering - speed: needed for VehicleEffectsSystem speed-based effects Buildings: - attackRange, sightRange: needed for GameOverlay range ring rendering Changes: 1. types.ts: Added new properties to UnitRenderState and BuildingRenderState interfaces, plus SerializedQueuedCommand type 2. GameWorker.ts: Updated collectUnitRenderState() and collectBuildingRenderState() to populate the new fields 3. RenderStateAdapter.ts: Updated UnitAdapter and BuildingComponentAdapter to expose the new properties https://claude.ai/code/session_01NUQdm7SkEPq2rQZcSFmRQf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.