fix: Address 4 critical codebase issues#1147
Merged
Merged
Conversation
1. Add 8 missing naval abilities (abilities.ts) - boost, flak_barrage, submerge, depth_charge_defense - beach_assault, amphibious_mode, shore_bombardment, yamato_cannon - Prevents runtime errors when naval units try to use abilities 2. Implement multiplayer lockstep barrier (Game.ts, GameCommand.ts) - Add HEARTBEAT command type for tick synchronization - Implement hasAllCommandsForTick() barrier check - Add heartbeat sending for ticks without player actions - Add timeout handling to prevent infinite hangs - Ensures both players execute same commands per tick 3. Add projectileType cross-reference validation (DefinitionValidator.ts) - Validates unit.projectileType references exist - Validates transformMode.projectileType references - Validates building.projectileType for turrets - Optional parameter maintains backwards compatibility 4. Refactor debug logger to use factory function (debugLogger.ts) - Reduces 118 lines of boilerplate to 38 lines - createCategoryLogger() factory generates all loggers - Same public API, no breaking changes https://claude.ai/code/session_01AxoTtAx1mKqsWq21g8h5Rf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 8 missing naval abilities (abilities.ts)
Implement multiplayer lockstep barrier (Game.ts, GameCommand.ts)
Add projectileType cross-reference validation (DefinitionValidator.ts)
Refactor debug logger to use factory function (debugLogger.ts)
https://claude.ai/code/session_01AxoTtAx1mKqsWq21g8h5Rf