fix: Wire performance panel to worker metrics with zero-cost when closed#1145
Merged
Merged
Conversation
The performance panel was completely broken because game logic runs exclusively in a Web Worker, which has its own PerformanceMonitor singleton. System timings and tick times were recorded in the worker but never sent to the main thread where the panel displays them. Changes: - Add WorkerPerformanceMetrics type and setPerformanceCollection message - Add PerformanceMonitor.applyWorkerMetrics() to receive worker data - Implement toggle-based collection in GameWorker (10Hz when enabled) - Wire WorkerBridge to forward metrics to main thread PerformanceMonitor - Enable collection on PerformanceDashboard mount, disable on unmount Performance characteristics: - Zero overhead when panel is closed (no timing, no messages) - 10Hz throttled metrics transfer when open (~100ms interval) - Efficient tuple serialization for system timings https://claude.ai/code/session_0129n4vJK6gWdvXSBUEfMwsv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The performance panel was completely broken because game logic runs exclusively in a Web Worker, which has its own PerformanceMonitor singleton. System timings and tick times were recorded in the worker but never sent to the main thread where the panel displays them.
Changes:
Performance characteristics:
https://claude.ai/code/session_0129n4vJK6gWdvXSBUEfMwsv