fix: Use Uint32BufferAttribute for geometry index buffers to fix WebG…#1144
Merged
Conversation
…PU errors WebGPU is stricter than WebGL about buffer types. Passing plain JavaScript arrays to geometry.setIndex() can cause "Failed to execute 'setIndexBuffer' on 'GPURenderPassEncoder': parameter 1 is not of type 'GPUBuffer'" errors. Fixed in: - BuildingPlacementPreview.ts (grid mesh) - Terrain.ts (terrain geometry and guardrails) - WaterMesh.ts (shore mesh) https://claude.ai/code/session_01VM695FVpXJe1mZjexmKoTx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…PU errors
WebGPU is stricter than WebGL about buffer types. Passing plain JavaScript arrays to geometry.setIndex() can cause "Failed to execute 'setIndexBuffer' on 'GPURenderPassEncoder': parameter 1 is not of type 'GPUBuffer'" errors.
Fixed in:
https://claude.ai/code/session_01VM695FVpXJe1mZjexmKoTx