fix: Fix idle workers display showing player1's workers when spectating#1143
Merged
Merged
Conversation
- Fix gameStore.syncWithGameSetup() to properly handle spectator mode by setting playerId to empty string when localPlayerId is null - Add syncWithGameSetup() call when game loading completes to ensure playerId is synced with the actual game setup state - Reset idle worker count to 0 in IdleWorkerButton when transitioning to spectator mode to prevent stale data display When spectating all-AI games, the playerId in gameStore was staying as 'player1' (the default) because syncWithGameSetup() only updated when localPlayerId was truthy. This caused the IdleWorkerButton to show player 1's workers even though the user was spectating. https://claude.ai/code/session_012UE6oa6ZDLCFVLJYwVW3b5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When spectating all-AI games, the playerId in gameStore was staying as 'player1' (the default) because syncWithGameSetup() only updated when localPlayerId was truthy. This caused the IdleWorkerButton to show player 1's workers even though the user was spectating.
https://claude.ai/code/session_012UE6oa6ZDLCFVLJYwVW3b5