refactor: unify overlay pipeline with OverlayCoordinator#1141
Merged
Conversation
Consolidate the split overlay system (TSL GameOverlay + Phaser OverlayScene) into a unified pipeline with a single coordinator class. Changes: - Create OverlayCoordinator singleton to own overlay state and coordinate TSLGameOverlayManager (3D) and OverlayScene (2D) via typed events - Remove dead code from OverlayScene (deprecated attack/vision/resource graphics that were migrated to TSL) - Implement Alt+A/Alt+V keyboard shortcuts for SC2-style hold-to-show attack and vision range overlays - Replace scattered UIStore subscriptions with coordinator-based updates - Add typed overlay events: overlay:typeChanged, overlay:rangeToggle, overlay:opacityChanged, overlay:navmeshProgress The coordinator provides a single API for input handlers and ensures consistent state across all overlay systems. https://claude.ai/code/session_01JCAYBr5BpixTZTA9Z9HMq5
Keep OverlayCoordinator-based approach for overlay management: - Use coordinator.setActiveOverlay() instead of direct refs access - Use coordinator.setShowAttackRange/VisionRange() for SC2-style hold-to-show behavior (show on keydown, hide on keyup) https://claude.ai/code/session_01JCAYBr5BpixTZTA9Z9HMq5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate the split overlay system (TSL GameOverlay + Phaser OverlayScene) into a unified pipeline with a single coordinator class.
Changes:
The coordinator provides a single API for input handlers and ensures consistent state across all overlay systems.
https://claude.ai/code/session_01JCAYBr5BpixTZTA9Z9HMq5