fix: Add geometry quarantine to BuildingRenderer and GameOverlay#1122
Merged
Conversation
Extends the geometry disposal quarantine pattern to additional renderers that were disposing geometry immediately while GPU still had pending draw commands. BuildingRenderer changes: - Add geometryQuarantine array and GEOMETRY_QUARANTINE_FRAMES constant - Add queueGeometryForDisposal() and processGeometryQuarantine() methods - Update disposeGroup() to use quarantine for effect disposal - Update refreshAllMeshes() to use quarantine for instanced groups - Update dispose() to flush quarantine during teardown GameOverlay (TSLGameOverlayManager) changes: - Add geometryQuarantine array and frame counter - Add queueGeometryForDisposal() and processGeometryQuarantine() methods - Update updateAttackRangeRings() to use quarantine when clearing rings - Update updateVisionRangeRings() to use quarantine when clearing rings - Update update() to process quarantine each frame - Update dispose() to flush quarantine during teardown The range ring disposal in GameOverlay was a likely culprit as it happens frequently during gameplay whenever unit selection changes. https://claude.ai/code/session_01LA6RwJfSB6nsab6v8oAGf9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the geometry disposal quarantine pattern to additional renderers that were disposing geometry immediately while GPU still had pending draw commands.
BuildingRenderer changes:
GameOverlay (TSLGameOverlayManager) changes:
The range ring disposal in GameOverlay was a likely culprit as it happens frequently during gameplay whenever unit selection changes.
https://claude.ai/code/session_01LA6RwJfSB6nsab6v8oAGf9