fix: Prevent WebGPU setIndexBuffer crash via geometry disposal quaran…#1120
Merged
Conversation
…tine The "setIndexBuffer" error occurred because geometries were disposed synchronously while WebGPU still had pending draw commands using those GPU buffers. WebGPU typically has 2-3 frames in flight. Added geometry disposal quarantine system that delays geometry and material disposal for 4 frames, ensuring the GPU has finished all pending draw commands before buffers are freed. Changes: - Add geometryQuarantine array and GEOMETRY_QUARANTINE_FRAMES constant - Add queueGeometryForDisposal() to queue resources for delayed cleanup - Add processGeometryQuarantine() called at start of each frame - Update inactive mesh cleanup to use quarantine instead of immediate disposal - Update refreshAllMeshes() to use quarantine - Update dispose() to flush quarantine during full teardown - Apply same pattern to GPUIndirectRenderer https://claude.ai/code/session_01LA6RwJfSB6nsab6v8oAGf9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tine
The "setIndexBuffer" error occurred because geometries were disposed synchronously while WebGPU still had pending draw commands using those GPU buffers. WebGPU typically has 2-3 frames in flight.
Added geometry disposal quarantine system that delays geometry and material disposal for 4 frames, ensuring the GPU has finished all pending draw commands before buffers are freed.
Changes:
https://claude.ai/code/session_01LA6RwJfSB6nsab6v8oAGf9