fix: Handle statePort access in worker context for building placement#1117
Merged
Merged
Conversation
The BuildingPlacementSystem.findWorkerForConstruction() was calling this.game.statePort.getSelectedUnits() which throws in the worker because WorkerGame doesn't have statePort (only Game does). This caused AI building placement to silently fail - the event was received, player type was detected, but then an exception was thrown before the worker could be assigned. Fix: Use optional chaining with fallback to empty array, since worker context has no selected units anyway (AI players don't select). https://claude.ai/code/session_01V4RhCiDvDJ7FmwSPYT74Y7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BuildingPlacementSystem.findWorkerForConstruction() was calling this.game.statePort.getSelectedUnits() which throws in the worker because WorkerGame doesn't have statePort (only Game does).
This caused AI building placement to silently fail - the event was received, player type was detected, but then an exception was thrown before the worker could be assigned.
Fix: Use optional chaining with fallback to empty array, since worker context has no selected units anyway (AI players don't select).
https://claude.ai/code/session_01V4RhCiDvDJ7FmwSPYT74Y7