Skip to content

fix: cache selection state snapshot to prevent React infinite loop #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braedonsaunders merged 1 commit into from
Jan 28, 2026
Merged

fix: cache selection state snapshot to prevent React infinite loop #1096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/engine/input/InputManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,13 @@ export class InputManager {
selectionEnd: { x: 0, y: 0 },
};

// Cached snapshot for useSyncExternalStore (must return same reference if unchanged)
private selectionStateSnapshot: SelectionState = {
isSelecting: false,
selectionStart: { x: 0, y: 0 },
selectionEnd: { x: 0, y: 0 },
};

// Double-click detection
private lastClick: { time: number; x: number; y: number } | null = null;

Expand Down Expand Up @@ -362,9 +369,10 @@ export class InputManager {

/**
* Get the current selection state
* Returns a cached snapshot for useSyncExternalStore compatibility
*/
public getSelectionState(): SelectionState {
return { ...this.selectionState };
return this.selectionStateSnapshot;
}

/**
Expand Down Expand Up @@ -428,7 +436,9 @@ export class InputManager {
}

private notifySelectionSubscribers(): void {
const state = this.getSelectionState();
// Update cached snapshot (creates new object reference for useSyncExternalStore)
this.selectionStateSnapshot = { ...this.selectionState };
const state = this.selectionStateSnapshot;
for (const subscriber of this.selectionSubscribers) {
subscriber(state);
}
Expand Down