fix: directly access globalThis in Minimap for adapter#1085
Merged
Conversation
Bypass getRenderStateAdapter() which may have stale code in code-split bundles. Instead, directly access globalThis with the adapter key. The issue: each code-split bundle may have its own copy of getRenderStateAdapter() compiled at different times. The Minimap's bundle was accessing a different singleton instance. Fix: const worldAdapter = globalThis['__voidstrike_RenderStateWorldAdapter__'] https://claude.ai/code/session_013SU8NkKifVUgpc4CLPcwL9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bypass getRenderStateAdapter() which may have stale code in code-split bundles. Instead, directly access globalThis with the adapter key.
The issue: each code-split bundle may have its own copy of getRenderStateAdapter() compiled at different times. The Minimap's bundle was accessing a different singleton instance.
Fix: const worldAdapter = globalThis['voidstrike_RenderStateWorldAdapter']
https://claude.ai/code/session_013SU8NkKifVUgpc4CLPcwL9