fix: resolve minimap blank and Phaser overlay issues in worker mode#1079
Merged
Conversation
Root causes identified and fixed:
1. **Phaser overlay auto-start issue**: The OverlayScene was auto-starting
before the eventBus was passed via scene.start(). Fixed by setting
`active: false` in the scene constructor to prevent auto-start.
2. **RenderStateAdapter improvements**:
- Fixed ResourceTransformAdapter ignoring z coordinate from data
- Added `isReady()`, `getUpdateCount()`, and `getEntityCounts()` methods
for debugging adapter state
- Added try-catch error handling around updateFromRenderState
- Added logging when adapter becomes ready with entities
- Reset ready state and update count in clear() method
3. **Minimap debugging**: Added periodic logging to check adapter state
until entities are found, helping diagnose data flow issues.
4. **OverlayScene logging**: Added comprehensive logging in init(),
create(), and setupEventListeners() to trace initialization flow.
https://claude.ai/code/session_019YKLEhajXF6s79S7Skr49F
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root causes identified and fixed:
Phaser overlay auto-start issue: The OverlayScene was auto-starting before the eventBus was passed via scene.start(). Fixed by setting
active: falsein the scene constructor to prevent auto-start.RenderStateAdapter improvements:
isReady(),getUpdateCount(), andgetEntityCounts()methods for debugging adapter stateMinimap debugging: Added periodic logging to check adapter state until entities are found, helping diagnose data flow issues.
OverlayScene logging: Added comprehensive logging in init(), create(), and setupEventListeners() to trace initialization flow.
https://claude.ai/code/session_019YKLEhajXF6s79S7Skr49F