Skip to content

fix: add type assertion for TS flow analysis in extractMaterial #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braedonsaunders merged 1 commit into from
Jan 26, 2026
Merged

fix: add type assertion for TS flow analysis in extractMaterial #1061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/rendering/InstancedDecorations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ function extractMaterial(object: THREE.Object3D, assetId?: string): THREE.Materi
if (!originalMaterial) return null;

// Clone the material to avoid modifying the original
const material = originalMaterial.clone();
// Type assertion needed because TS doesn't track callback assignments
const material = (originalMaterial as THREE.Material).clone();

// Apply rendering hints for MeshStandardMaterial
if ((material as THREE.MeshStandardMaterial).isMeshStandardMaterial) {
Expand Down