fix(render): add separate death effect pool to prevent WebGPU geometr…#1056
Merged
Conversation
…y swap crash BattleEffectsRenderer was swapping geometry on pooled meshes at runtime: - Acquired mesh from groundEffectPool (uses groundRingGeometry) - Swapped geometry to largeRingGeometry for death effects - Swapped back to groundRingGeometry when effect completed WebGPU has strict buffer management and doesn't handle geometry swapping well on meshes. This caused the "setIndexBuffer: parameter 1 is not of type GPUBuffer" crash after ~7 minutes of gameplay. Fix: Create a separate deathEffectPool that uses largeRingGeometry from creation, avoiding any geometry swapping at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…y swap crash
BattleEffectsRenderer was swapping geometry on pooled meshes at runtime:
WebGPU has strict buffer management and doesn't handle geometry swapping well on meshes. This caused the "setIndexBuffer: parameter 1 is not of type GPUBuffer" crash after ~7 minutes of gameplay.
Fix: Create a separate deathEffectPool that uses largeRingGeometry from creation, avoiding any geometry swapping at runtime.