fix(render): clone geometry in all renderers to prevent WebGPU crash#1055
Merged
Conversation
The previous fix only addressed GPUIndirectRenderer, but BuildingRenderer, UnitRenderer, and ResourceRenderer also shared geometry from the asset cache without cloning. When instanced groups were cleaned up during LOD changes or inactive mesh cleanup cycles, the shared GPU buffers were disposed while still referenced by other meshes. Changes: - UnitRenderer: Clone geometry when creating instanced groups, dispose geometry during cleanup (lines 719, 1183, 1251, 1333) - BuildingRenderer: Clone geometry when creating instanced groups, dispose geometry during cleanup (lines 283, 243, 2416) - ResourceRenderer: Clone geometry when creating instanced groups (line 197) The ~7 minute crash timing corresponds to the INACTIVE_MESH_CLEANUP_FRAMES threshold combined with entity spawning/despawning patterns in a 6-player AI game causing enough cleanup cycles to hit the race condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix only addressed GPUIndirectRenderer, but BuildingRenderer, UnitRenderer, and ResourceRenderer also shared geometry from the asset cache without cloning. When instanced groups were cleaned up during LOD changes or inactive mesh cleanup cycles, the shared GPU buffers were disposed while still referenced by other meshes.
Changes:
The ~7 minute crash timing corresponds to the INACTIVE_MESH_CLEANUP_FRAMES threshold combined with entity spawning/despawning patterns in a 6-player AI game causing enough cleanup cycles to hit the race condition.