Guard shutdown task against accidental production runs - #1
Open
bradydibble wants to merge 1 commit into
Open
Conversation
The shutdown task in gather_facts_ephemeral.yml previously fired on all non-Windows hosts. If the playbook was ever run with a misconfigured limit or against 'all', it would shut down production machines. Add a group_names intersect guard so shutdown only fires on hosts in linux_test_vms or game_servers groups — the only groups where ephemeral shutdown is expected. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gather_facts_ephemeral.ymlpreviously fired on all non-Windows hostsall, it would shut down production machinesgroup_names | intersectguard so shutdown only fires onlinux_test_vmsorgame_servershostsWhat happened
The playbook was accidentally assigned to Ascender templates targeting production hosts (cairn-02, cairn-03). Both machines shut down while the admin was 300 miles away.
Test plan
ansible-playbook --check --diffagainst an inventory with production hosts — shutdown should showskippingrlc_test_vms,oracle_test_vms, etc.) still inheritlinux_test_vmsmembership🤖 Generated with Claude Code