Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bugs mentioned in #12
https://github.com/bradford-hamilton/dora/blob/master/pkg/parser/parser.go#L211-L216
An Error in the input string is detected, but forgets to return, causing an infinite
for
loop.https://github.com/bradford-hamilton/dora/blob/master/pkg/parser/parser.go#L302-L307
An Error in the input string is detected, but forgets to return, causing an infinite
for
loop.https://github.com/bradford-hamilton/dora/blob/master/pkg/lexer/lexer.go#L166-L169
l.char == 0
breaks the loop if0
is found in JSON payload, butl.advanceChar()
which was already done before that causesl.position
to get incremented causing the slice to hit out of bound.https://github.com/bradford-hamilton/dora/blob/master/pkg/parser/parser.go#L314-L319
An Error in the input string is detected, but forgets to return, causing an infinite
for
loop.