Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix #13

wants to merge 2 commits into from

Conversation

cooliscool
Copy link

Fixing bugs mentioned in #12

  1. https://github.com/bradford-hamilton/dora/blob/master/pkg/parser/parser.go#L211-L216
    An Error in the input string is detected, but forgets to return, causing an infinite for loop.

  2. https://github.com/bradford-hamilton/dora/blob/master/pkg/parser/parser.go#L302-L307
    An Error in the input string is detected, but forgets to return, causing an infinite for loop.

  3. https://github.com/bradford-hamilton/dora/blob/master/pkg/lexer/lexer.go#L166-L169
    l.char == 0 breaks the loop if 0 is found in JSON payload, but l.advanceChar() which was already done before that causes l.position to get incremented causing the slice to hit out of bound.

  4. https://github.com/bradford-hamilton/dora/blob/master/pkg/parser/parser.go#L314-L319
    An Error in the input string is detected, but forgets to return, causing an infinite for loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant