-
-
Notifications
You must be signed in to change notification settings - Fork 93
perf(ingestor_livetiming): add opt-in concurrency/parallelism for historical data ingestion #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JeffreyJPZ
wants to merge
22
commits into
br-g:main
Choose a base branch
from
JeffreyJPZ:ingest-historical-perf-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7a52609
add async and multiprocessing support
JeffreyJPZ b3a55fe
make async write batch size 50000
JeffreyJPZ 7681945
fix errors
JeffreyJPZ 7f125df
move 'multiprocessing' module to 'util'
JeffreyJPZ 3acc829
add optional 'max_workers' and 'batch_size' args
JeffreyJPZ ae4c697
update README
JeffreyJPZ e016ed9
lint fix
JeffreyJPZ e9d798d
add typer wrapper for decorating async functions
JeffreyJPZ 8cf5f00
fix README
JeffreyJPZ 86a4694
fix missing documents when parallel is enabled
JeffreyJPZ 43756c1
change default batch size to 10
JeffreyJPZ 433c7ed
fix type error, remove parallel flag for non-ingestion commands
JeffreyJPZ f4064b5
remove parallel flag for get-messages
JeffreyJPZ 78ffa5e
lint fix
JeffreyJPZ 47dd876
remove multiprocessing
JeffreyJPZ 11f87b7
reuse async http client
JeffreyJPZ fef3db3
remove timeout for http client session
JeffreyJPZ 6ef6472
lint fix
JeffreyJPZ e6117ee
update README
JeffreyJPZ 2ccf233
add 'by-meeting' and 'by-session' flags
JeffreyJPZ b74fda6
update requirements.txt
JeffreyJPZ 298603e
run commands with new event loop if closed
JeffreyJPZ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't exactly like propagating these through all of the functions (very easy to forget), but I'm not sure what other options there are.