Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Make transform result internal stuff #23

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

bpolaszek
Copy link
Owner

  • Renamed TransformEvent::items to TransformEvent::transformResult because the result could be a single item
  • TransformEvent::transformResult can now be a single scalar result

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc68466) 100.00% compared to head (0591068) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #23   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       222       227    +5     
===========================================
  Files             46        47    +1     
  Lines            661       677   +16     
===========================================
+ Hits             661       677   +16     
Files Coverage Δ
src/EtlExecutor.php 100.00% <100.00%> (ø)
src/EventDispatcher/Event/TransformEvent.php 100.00% <ø> (ø)
src/Internal/TransformResult.php 100.00% <100.00%> (ø)
src/Recipe/LoggerRecipe.php 100.00% <100.00%> (ø)
src/Transformer/ChainTransformer.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bpolaszek bpolaszek merged commit 954c2fa into master Nov 9, 2023
4 checks passed
@bpolaszek bpolaszek deleted the feature/transform-result branch November 9, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant