Repository navigation
Housekeeping - #13
Merged
Merged
Housekeeping#13
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s development tooling baseline (linting, testing, dependencies) and introduces a GitHub Actions CI workflow to run the standard build pipeline on pushes/PRs.
Changes:
- Upgrades key devDependencies (ESLint v9 + flat config, Mocha/Chai, Puppeteer, Karma-related packages).
- Switches ESLint configuration from legacy
.eslintrc/.eslintignoretoeslint.config.mjs. - Adds a CI workflow and adjusts Karma to use Puppeteer-provided Chrome.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/spec/commentsSpec.js | Adds explicit Chai expect import (consistent with removing sinon-chai Karma integration). |
| test/.eslintrc | Removes legacy test ESLint config (replaced by flat config). |
| package.json | Modernizes toolchain dependencies and swaps npm-run-all → npm-run-all2. |
| karma.conf.js | Uses Puppeteer Chrome binary and removes sinon-chai framework from Karma. |
| eslint.config.mjs | Introduces ESLint flat config with browser/node/mocha presets and global ignores. |
| .github/workflows/CI.yml | Adds CI workflow running npm ci + npm run all. |
| .eslintrc | Removes legacy ESLint config (replaced by flat config). |
| .eslintignore | Removes legacy ignore file (replaced by flat config ignores). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+2
| // use puppeteer provided Chrome for testing | ||
| process.env.CHROME_BIN = require('puppeteer').executablePath(); |
Comment on lines
+41
to
+42
| "sinon": "^21.1.2", | ||
| "sinon-chai": "^4.0.1", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool