Skip to content

Housekeeping - #13

Merged
barmac merged 10 commits into
mainfrom
housekeeping
May 4, 2026
Merged

barmac merged 10 commits into
mainfrom
housekeeping

Conversation

@nikku

@nikku nikku commented May 4, 2026

Copy link
Copy Markdown
Member

Proposed Changes

  • Lifts up the project to our modern foundations
  • Adds CI 😉

Checklist

Ensure you provide everything we need to review your contribution:

  • Contribution meets our definition of done
  • Pull request establishes context
    • Link to related issue(s), i.e. Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}
    • Brief textual description of the changes
    • Screenshots or short videos showing UI/UX changes
    • Steps to try out, i.e. using the @bpmn-io/sr tool

@nikku
nikku requested review from a team and Copilot May 4, 2026 08:19
@bpmn-io-tasks bpmn-io-tasks Bot added the needs review Review pending label May 4, 2026
@nikku nikku added the dependencies Updates a dependency label May 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s development tooling baseline (linting, testing, dependencies) and introduces a GitHub Actions CI workflow to run the standard build pipeline on pushes/PRs.

Changes:

  • Upgrades key devDependencies (ESLint v9 + flat config, Mocha/Chai, Puppeteer, Karma-related packages).
  • Switches ESLint configuration from legacy .eslintrc/.eslintignore to eslint.config.mjs.
  • Adds a CI workflow and adjusts Karma to use Puppeteer-provided Chrome.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/spec/commentsSpec.js Adds explicit Chai expect import (consistent with removing sinon-chai Karma integration).
test/.eslintrc Removes legacy test ESLint config (replaced by flat config).
package.json Modernizes toolchain dependencies and swaps npm-run-all → npm-run-all2.
karma.conf.js Uses Puppeteer Chrome binary and removes sinon-chai framework from Karma.
eslint.config.mjs Introduces ESLint flat config with browser/node/mocha presets and global ignores.
.github/workflows/CI.yml Adds CI workflow running npm ci + npm run all.
.eslintrc Removes legacy ESLint config (replaced by flat config).
.eslintignore Removes legacy ignore file (replaced by flat config ignores).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread karma.conf.js
Comment on lines +1 to +2
// use puppeteer provided Chrome for testing
process.env.CHROME_BIN = require('puppeteer').executablePath();
Comment thread package.json Outdated
Comment on lines +41 to +42
"sinon": "^21.1.2",
"sinon-chai": "^4.0.1",
@barmac
barmac merged commit 6623f10 into main May 4, 2026
3 checks passed
@bpmn-io-tasks bpmn-io-tasks Bot removed the needs review Review pending label May 4, 2026
@barmac
barmac deleted the housekeeping branch May 4, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Updates a dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants