feat(profile): Add social and academic profile section #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ritesh-Udgata
commented
Sep 8, 2025
Ritesh-Udgata
commented
- Add new SocialAcademicProfile component with form handling
- Integrate LinkedIn, ORCID, Scopus, and Google Scholar fields
- Add validation using Zod schema
- Update TypeScript types and interfaces
- Integrate with existing profile edit endpoint
- Add new SocialAcademicProfile component with form handling - Integrate LinkedIn, ORCID, Scopus, and Google Scholar fields - Add validation using Zod schema - Update TypeScript types and interfaces - Integrate with existing profile edit endpoint
- Remove unused imports and variables - Update toast implementation to use Sonner - Fix mutation status checks (isPending -> isLoading) - Update component dependencies and imports
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new social and academic profile section to the user profile interface, allowing users to manage their LinkedIn, ORCID, Scopus, and Google Scholar profiles.
- Introduces a new SocialAcademicProfile component with form validation using Zod
- Updates profile-related TypeScript interfaces and type definitions
- Adds toast notification system and theme provider integration
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| server/package.json | Added dev script for development server |
| lib/src/types/auth.ts | Extended auth types with profile data interfaces |
| client/src/lib/api.ts | Created axios API client with authentication |
| client/src/components/ui/use-toast.ts | Added toast hook and state management |
| client/src/components/ui/toaster.tsx | Created Toaster component wrapper |
| client/src/components/ui/toast.tsx | Implemented toast UI components |
| client/src/components/profile/UserProfile.tsx | Integrated new social profile component |
| client/src/components/profile/SocialAcademicProfile.tsx | New form component for social/academic profiles |
| client/src/components/Providers.tsx | Added theme provider and updated toaster |
| client/package.json | Updated dependencies and TypeScript version |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+35
to
+40
| defaultValues: { | ||
| linkedin: profileData?.linkedin || "", | ||
| orchidID: profileData?.orchidID || "", | ||
| scopusID: profileData?.scopusID || "", | ||
| googleScholar: profileData?.googleScholar || "", | ||
| }, |
There was a problem hiding this comment.
The form default values are set during initialization but won't update when profileData loads asynchronously. Use the reset method in a useEffect to update form values after data loads, or use the values prop instead of defaultValues.
…on load - Set TOAST_REMOVE_DELAY from 1000000ms to 5000ms for better UX - Switch mutation status to isPending for disabled/loading state - Reset RHF values via useEffect when profileData loads to sync defaults Files: - client/src/components/ui/use-toast.ts - client/src/components/profile/SocialAcademicProfile.tsx Signed-off-by: Ritesh <[email protected]>
Signed-off-by: Ritesh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.