fix(firewall): handle case insensitive security group names

[bpg]

Contributor's Note

• I have added / updated documentation in /docs for any user-facing features or additions.
• I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
• I have ran make example to verify that the change works as expected.

Proof of Work

See new acceptance tests.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #769

[gemini-code-assist]

Summary of Changes

Hello @bpg, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the Proxmox Terraform provider was not correctly interpreting firewall security group names due to case sensitivity. The changes introduce robust case-insensitive matching for security group names during all lifecycle operations, ensuring that resources are consistently identified and managed, thereby improving the reliability and user experience of the firewall security group resource. This directly addresses and closes issue #769.

Highlights

• Case-Insensitive Security Group Names: Implemented logic to handle Proxmox firewall security group names in a case-insensitive manner across create, read, and update operations.
• New Helper Function: Introduced a new internal helper function, findActualGroupName, to perform case-insensitive lookups for security group names as they are stored in Proxmox.
• Updated Resource Operations: Modified the SecurityGroupCreate, SecurityGroupRead, and SecurityGroupUpdate functions to utilize the new case-insensitive lookup, ensuring consistent behavior regardless of the casing used in Terraform configurations.
• Acceptance Test Coverage: Added a new acceptance test case to specifically validate the correct handling of security group names containing capital letters.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses case-insensitive handling for security group names by using strings.EqualFold for comparisons. The addition of an acceptance test is also a good step. My review includes a critical fix to prevent perpetual diffs in Terraform plans, along with suggestions to improve code maintainability by reducing duplication and enhancing the new test case for better coverage.