Clarify license, move to pyproject.toml, always use preview mode#41
Open
dschwoerer wants to merge 3 commits into
Open
Clarify license, move to pyproject.toml, always use preview mode#41dschwoerer wants to merge 3 commits into
dschwoerer wants to merge 3 commits into
Conversation
ZedThree
approved these changes
Apr 28, 2026
Member
ZedThree
left a comment
ZedThree
left a comment
There was a problem hiding this comment.
This is fine as a straight conversion, but there's a few things we could do to improve it as well
| "Programming Language :: Python :: 3.14", | ||
| "Topic :: Scientific/Engineering :: Physics" | ||
| ] | ||
| dependencies = ["xarray", "xbout"] |
Member
There was a problem hiding this comment.
We should also add numpy, matplotlib, and netcdf. Also worth using SPEC0 minimum versions, as well as requires-python and dependency-groups for the dev tools
Collaborator
There was a problem hiding this comment.
Since the dependencies should be the same as xBOUT's for now, why not just have xbout in there? This way we make sure the dependencies are always the same for both
Co-authored-by: Peter Hill <zed.three@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.